Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visualizer): randomize sinusoid amplitudes #1169

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Feb 21, 2024

Description of change

Fixes #1165

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Amplitudes vary over time (screenshot also with random periods)
Captura de pantalla 2024-02-22 003657

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad linked an issue Feb 21, 2024 that may be closed by this pull request
Base automatically changed from feat/nova-visualizer/randomize-period to dev February 22, 2024 09:32
Copy link
Collaborator

@msarcev msarcev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a conflicts infestation.

@VmMad
Copy link
Member Author

VmMad commented Feb 22, 2024

This PR has a conflicts infestation.

infestation 😭

@VmMad VmMad requested a review from msarcev February 22, 2024 10:05
@msarcev msarcev merged commit 3d3bb50 into dev Feb 22, 2024
4 of 6 checks passed
@msarcev msarcev deleted the feat/nova-visualizer/randomize-amplitude branch February 22, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Randomize sinusoid amplitude
2 participants